jackye1995 commented on pull request #3294: URL: https://github.com/apache/iceberg/pull/3294#issuecomment-987139569
Thanks for continuing the work! FYI, I already imported the in-memory catalog to https://github.com/prestodb/presto/pull/17046. The overall implementation looks good to me for the catalog. I am a bit unsure about the `InMemoryFileIO` part. Do you think it's actually practical to store all the bytes in a map? The FileIO would be serialized and passed around worker nodes, storing all data in memory would cause serialization failure when payload is too large. Would it be more useful to have a `LocalFileIO` instead of `InMemoryFileIO`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
