RussellSpitzer commented on a change in pull request #3292:
URL: https://github.com/apache/iceberg/pull/3292#discussion_r764154881



##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -109,14 +110,11 @@ public String toString() {
     private final List<Long> offsets;
     private final List<Long> splitSizes;
     private final FileScanTask parentScanTask;
-    private final long targetSplitSize;
     private int sizeIdx = 0;
 
-    OffsetsAwareTargetSplitSizeScanTaskIterator(
-        List<Long> offsetList, FileScanTask parentScanTask, long 
targetSplitSize) {
+    OffsetsAwareTargetSplitSizeScanTaskIterator(List<Long> offsetList, 
FileScanTask parentScanTask) {

Review comment:
       Changing the behavior here to just always produce splits that are the 
size of a row group. Split-Size is not used here, only when recombining.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to