jackye1995 commented on pull request #3638: URL: https://github.com/apache/iceberg/pull/3638#issuecomment-988210539
@aokolnychyi ah totally forgot that. We can either: 1. change to use hash map, to keep it Kyro serializable 2. just make it not implement `Serializable` 3. keep it as is IMO (1) seems like the preferred way, because we cannot change public interface to achieve (2), and if we go with (3) it might create a false impression that the object is Kyro serializable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
