ajantha-bhat commented on a change in pull request #3685:
URL: https://github.com/apache/iceberg/pull/3685#discussion_r764581584



##########
File path: 
spark/v2.4/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkActions.java
##########
@@ -44,6 +44,11 @@ public DeleteOrphanFiles deleteOrphanFiles(Table table) {
     return new BaseDeleteOrphanFilesSparkAction(spark, table);
   }
 
+  @Override
+  public RewriteDataFiles rewriteDataFiles(Table table) {
+    return new BaseRewriteDataFilesSparkAction(spark, table);

Review comment:
       @RussellSpitzer : I should have something like Spark3BinPackStrategy and 
Spark3SortStrategy.
   Then call that from BaseRewriteDataFilesSparkAction2 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to