jun-he commented on a change in pull request #3601:
URL: https://github.com/apache/iceberg/pull/3601#discussion_r765087113



##########
File path: python/tests/test_types.py
##########
@@ -15,149 +15,548 @@
 # specific language governing permissions and limitations
 # under the License.
 
+import decimal
+import math
+
 import pytest
 
 from iceberg.types import (
-    BinaryType,
-    BooleanType,
-    DateType,
-    DecimalType,
-    DoubleType,
-    FixedType,
-    FloatType,
-    IntegerType,
-    ListType,
-    LongType,
-    MapType,
+    UUID,
+    Binary,
+    Boolean,
+    Date,
+    Decimal,
+    Double,
+    Fixed,
+    Float,
+    IcebergType,
+    Integer,
+    List,

Review comment:
       Wondering if those names will cause some inconvenience for users when to 
use iceberg types or other classes with the same name from python or other 
libraries.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to