jackye1995 commented on a change in pull request #3687:
URL: https://github.com/apache/iceberg/pull/3687#discussion_r765268155
##########
File path:
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/TestLocalAliyunOSS.java
##########
@@ -69,6 +70,9 @@ public void after() {
@Test
public void testBuckets() {
+ Assume.assumeTrue("Aliyun integration test cannot delete existing bucket
from test environment.",
+ OSS_TEST_RULE.getClass() == AliyunOSSMockRule.class);
Review comment:
In AWS we just assumes the bucket exists, and create a random prefix as
the root for all tests. By doing that we don't deal with bucket deletion, which
is quite dangerous as you say. Would that be better also for Aliyun?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
