rdblue commented on a change in pull request #3642:
URL: https://github.com/apache/iceberg/pull/3642#discussion_r765945193
##########
File path: build.gradle
##########
@@ -111,7 +111,9 @@ subprojects {
targetCompatibility = '1.8'
dependencies {
- implementation 'org.slf4j:slf4j-api'
+ if (!(project.name.contains("spark") && project.name.contains("runtime")))
{
+ implementation 'org.slf4j:slf4j-api'
+ }
Review comment:
I don't think this is the right way to do this. We want to only change
the iceberg-spark-runtime-3.2_2.12 module, not all Spark runtime modules. The
others work fine so there's no need to change them.
I think we have 2 options. First, we can move this implementation dependency
into every module. That may be the most straightforward. Second, I think we
could probably suppress this in just the iceberg-spark-runtime-3.2_2.12 module
using something like this:
```
configurations {
implementation {
exclude group: 'org.slf4j', module: 'slf4j-api'
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
