kbendick commented on a change in pull request #3694:
URL: https://github.com/apache/iceberg/pull/3694#discussion_r766244549
##########
File path: site/docs/configuration.md
##########
@@ -60,11 +60,11 @@ Iceberg tables support table properties to configure table
behavior, like the de
| commit.retry.num-retries | 4 | Number of times to
retry a commit before failing |
| commit.retry.min-wait-ms | 100 | Minimum time in
milliseconds to wait before retrying a commit |
| commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in
milliseconds to wait before retrying a commit |
-| commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in
milliseconds to wait before retrying a commit |
+| commit.retry.total-timeout-ms | 1800000 (30 min) | Totals retry timeout
period in milliseconds for a commit |
Review comment:
Nit: `Total` has an extra `s` on the end.
##########
File path: site/docs/configuration.md
##########
@@ -60,11 +60,11 @@ Iceberg tables support table properties to configure table
behavior, like the de
| commit.retry.num-retries | 4 | Number of times to
retry a commit before failing |
| commit.retry.min-wait-ms | 100 | Minimum time in
milliseconds to wait before retrying a commit |
| commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in
milliseconds to wait before retrying a commit |
-| commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in
milliseconds to wait before retrying a commit |
+| commit.retry.total-timeout-ms | 1800000 (30 min) | Totals retry timeout
period in milliseconds for a commit |
| commit.status-check.num-retries | 3 | Number of times to
check whether a commit succeeded after a connection is lost before failing due
to an unknown commit state |
| commit.status-check.min-wait-ms | 1000 (1s) | Minimum time in
milliseconds to wait before retrying a status-check |
| commit.status-check.max-wait-ms | 60000 (1 min) | Maximum time in
milliseconds to wait before retrying a status-check |
-| commit.status-check.total-timeout-ms| 1800000 (30 min) | Maximum time in
milliseconds to wait before retrying a status-check |
+| commit.status-check.total-timeout-ms| 1800000 (30 min) | Totals status-check
timeout period in milliseconds |
Review comment:
Nit / non-blocking: Consider `Total timeout period in which the commit
status-check must succeed, in milliseconds`
Also, `Total` has an extra `s` presently here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
