kbendick commented on a change in pull request #3543:
URL: https://github.com/apache/iceberg/pull/3543#discussion_r766272396
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogConfig.java
##########
@@ -34,7 +34,8 @@
"type", "hive",
"default-namespace", "default",
"parquet-enabled", "true",
- "cache-enabled", "false" // Spark will delete tables using v1, leaving
the cache out of sync
+ "cache-enabled", "false", // Spark will delete tables using v1, leaving
the cache out of sync
+ "cache.expiration-interval-ms", "0" // Cache expiration needs to be
disabled if cache is
Review comment:
Not if we're defaulting to zero now (aka off).
This was to make the tests predictable. At least at one point it was an
error to have a non-zero cache.expiration-interval-ms with `cache-enabled` as
false.
Part of the problem is that we continue to send those properties further
down into the call, which is why I normalized them. Let me try removing this
now since it's currently defaulted to zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
