RussellSpitzer commented on pull request #3685: URL: https://github.com/apache/iceberg/pull/3685#issuecomment-990586810
If we are reverting all the deprecation messages also need to be changed, they currently say the function will be removed in 0.13. We also don't need to support Sort in 2.4, it never was supported before in 2.4. I mainly don't want to keep this around because the old api had some odd behaviors, if we bring it back we then have two different apis depending on the Spark version which will do materially different things. Although if we want to maintain that as a long term support I think that could be fine. The main issue is many of the 3.0 actions are just very difficult to implement in 2.4 (like snapshot and migrate) which I only originally implemented for Spark 3. https://github.com/apache/iceberg/pull/1525/files So if we do revert, it probably only makes sense to move back `rewriteDataFiles` as I don't think any of the other actions had implementations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
