samredai commented on a change in pull request #3691:
URL: https://github.com/apache/iceberg/pull/3691#discussion_r766786207



##########
File path: python/pyproject.toml
##########
@@ -17,7 +17,8 @@
 
 [build-system]
 requires = [
+    "boto3==1.19.2",

Review comment:
       Thanks @TGooch44, I removed the pin and I'll update the PR with the 
import guards. I also moved the boto3 requirement to an `s3` extras block in 
`setup.py`. I'll add an item to the next python sync to discuss this but I 
think there's value in having optional dependency sets that let users only 
install what they need. For example a user doesn't get boto3 unless they do 
`pip3 install py-iceberg[s3]`. This will let those going with their own custom 
file io and custom catalog to just install the core components with `pip3 
install py-iceberg`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to