kbendick commented on a change in pull request #3543: URL: https://github.com/apache/iceberg/pull/3543#discussion_r766949951
########## File path: core/src/test/java/org/apache/iceberg/util/FakeTicker.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.util; + +import com.github.benmanes.caffeine.cache.Ticker; +import java.time.Duration; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicLong; + +/** + * A Ticker whose value can be advanced programmatically in test. + * + * This is modified from the Guava package com.google.common.testing.FakeTicker, Review comment: I have actually removed all of the Guava code from this. This is an implementation of the interface from `caffeine`, and there are no methods from the Guava class in it anymore. I can remove that part at the top, as there are many `FakeTicker`s abounding on the internet. This one only uses nanos because that's what the interface uses. But I did not run across one that used a `Duration` as input. So this is arguably not from Guava anymore (plus we do credit Guava already). Up to you how to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
