rdblue commented on a change in pull request #3543:
URL: https://github.com/apache/iceberg/pull/3543#discussion_r767062166
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -83,7 +89,8 @@
private String catalogName = null;
private Catalog icebergCatalog = null;
- private boolean cacheEnabled = true;
+ private boolean cacheEnabled = CatalogProperties.TABLE_CACHE_ENABLED_DEFAULT;
+ private long cacheExpirationIntervalMs =
CatalogProperties.TABLE_CACHE_EXPIRATION_INTERVAL_MS_DEFAULT;
Review comment:
Do these need to be fields? Can we remove them and just make them local
within `initialize`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
