rdblue commented on a change in pull request #3720:
URL: https://github.com/apache/iceberg/pull/3720#discussion_r767913112
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java
##########
@@ -148,19 +152,23 @@ public String rewrittenFileSetId() {
}
public DistributionMode distributionMode() {
- String defaultValue;
- if (table.sortOrder().isSorted()) {
- defaultValue = TableProperties.WRITE_DISTRIBUTION_MODE_RANGE;
- } else {
- defaultValue = TableProperties.WRITE_DISTRIBUTION_MODE_DEFAULT;
Review comment:
I think we should follow up and deprecate it. We can do that in a PR
that updates Flink to set its own default like here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
