jackye1995 commented on pull request #3698: URL: https://github.com/apache/iceberg/pull/3698#issuecomment-992723732
I think that is already tested in `testCreateNamespaceBadName` and `testToDatabaseNameFailure`. `TestGlueCatalog` does not have the table name test because verification of the table name is done in `BaseMetastoreCatalog` through `isValidIdentifier`. But I agree the current `TestGlueCatalog` lacks a lot of features. I am thinking about implementing a proper local Glue client to test the code in unit test properly, let me know if you would like to pick up the task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
