CodingCat commented on pull request #3632: URL: https://github.com/apache/iceberg/pull/3632#issuecomment-993159414
Hi, all, Thank you for the review, I am currently on vacation without my laptop, will address them after Dec 20 Thanks! Nan On Sun, Dec 12, 2021 at 12:40 PM Ryan Blue ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In core/src/test/java/org/apache/iceberg/TestUpdatePartitionSpec.java > <https://github.com/apache/iceberg/pull/3632#discussion_r767338618>: > > > @@ -614,6 +605,65 @@ public void testRemoveAndAddMultiTimes() { > V2Assert.assertEquals("Should match expected spec", v2Expected, updated); > } > > + @Test > + public void testRemoveAndUpdateWithIdentity() { > > I'm not sure that this is a valid case. It is currently allowed by the > updated implementation, but this is a case that we originally wanted to > prevent with the check for adding a deleted field. I think that the update > should only allow adding a field with the same name if it uses a different > transform. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/3632#pullrequestreview-829679003>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFFQ6CFEN2SBCM3W4IWMYTUQUQFJANCNFSM5JCUB6CA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
