CodingCat commented on pull request #3663: URL: https://github.com/apache/iceberg/pull/3663#issuecomment-993159672
Hi, all, Thanks for the review! I am currently on vacation without my laptop , will address the comments after Dec 20 Thanks! Nan On Sun, Dec 12, 2021 at 9:25 AM Ryan Blue ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java > <https://github.com/apache/iceberg/pull/3663#discussion_r767316693>: > > > try { > + lockManager.acquire(dst.toString(), Thread.currentThread().getName()); > + if (fs.exists(dst)) { > + throw new CommitFailedException("Version %d already exists: %s", nextVersion, dst); > + } > > Nit: please add a newline between control flow blocks and the following > statement. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/3663#pullrequestreview-829660825>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFFQ6F425IPL6VFFVROI63UQTZJRANCNFSM5JKZG27A> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
