rajarshisarkar commented on a change in pull request #3732:
URL: https://github.com/apache/iceberg/pull/3732#discussion_r768767088



##########
File path: site/docs/spark-configuration.md
##########
@@ -155,6 +155,7 @@ spark.read
 | file-open-cost  | As per table property | Overrides this table's 
read.split.open-file-cost                                          |
 | vectorization-enabled  | As per table property | Overrides this table's 
read.parquet.vectorization.enabled                                          |
 | batch-size  | As per table property | Overrides this table's 
read.parquet.vectorization.batch-size                                          |
+| stream-from-timestamp | Long.MIN_VALUE | Timestamp in milliseconds; start a 
stream from the snapshot that occurs after this timestamp. |

Review comment:
       Hi @kbendick 
   
   Thanks for reviewing!
    
   `stream-from-timestamp` would actually stream the table from the snapshot >= 
timestamp. Here's an example: 
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java#L109-L117
   
   Hence, I have kept the description as `Timestamp in milliseconds, start 
streaming this table from the first snapshot that occurs strictly after this 
timestamp`. 
   
   Please let me know if we can phrase it better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to