rdblue commented on a change in pull request #3743:
URL: https://github.com/apache/iceberg/pull/3743#discussion_r769129703
##########
File path: deploy.gradle
##########
@@ -24,105 +24,108 @@ if (project.hasProperty('release') && jdkVersion != '8') {
subprojects {
apply plugin: 'maven-publish'
apply plugin: 'signing'
+ afterEvaluate {
- task sourceJar(type: Jar, dependsOn: classes) {
- classifier = 'sources'
- from sourceSets.main.allSource
- group 'build'
- }
+ task sourceJar(type: Jar, dependsOn: classes) {
+ classifier = 'sources'
+ from sourceSets.main.allSource
+ group 'build'
+ }
- task javadocJar(type: Jar, dependsOn: javadoc) {
- classifier = 'javadoc'
- from javadoc.destinationDir
- group 'build'
- }
+ task javadocJar(type: Jar, dependsOn: javadoc) {
+ classifier = 'javadoc'
+ from javadoc.destinationDir
+ group 'build'
+ }
- task testJar(type: Jar) {
- archiveClassifier = 'tests'
- from sourceSets.test.output
- }
+ task testJar(type: Jar) {
+ archiveClassifier = 'tests'
+ from sourceSets.test.output
+ }
- artifacts {
- archives sourceJar
- archives javadocJar
- archives testJar
- testArtifacts testJar
- }
+ artifacts {
+ archives sourceJar
+ archives javadocJar
+ archives testJar
+ testArtifacts testJar
+ }
- // add LICENSE and NOTICE
- [jar, sourceJar, javadocJar, testJar].each { task ->
- task.from(rootDir) {
- include 'LICENSE'
- include 'NOTICE'
+ // add LICENSE and NOTICE
+ [jar, sourceJar, javadocJar, testJar].each { task ->
Review comment:
I don't think that this was added by this PR. I think everything in the
block was indented with no other change (at least, from ignore whitespace diff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
