rdblue commented on a change in pull request #3733:
URL: https://github.com/apache/iceberg/pull/3733#discussion_r769138135
##########
File path: core/src/test/java/org/apache/iceberg/TestTransaction.java
##########
@@ -699,4 +700,23 @@ public void
testTransactionRewriteManifestsAppendedDirectly() throws IOException
Assert.assertFalse("Append manifest should be deleted on expiry", new
File(newManifest.path()).exists());
}
+
+ @Test
+ public void testSimpleTransactionNotDeletingMetadataOnUnknownSate() throws
IOException {
+ Table table = TestTables.tableWithCommitSucceedButStateUnknown(tableDir,
"test");
+
+ Transaction transaction = table.newTransaction();
+ transaction.newAppend()
+ .appendFile(FILE_A)
+ .commit();
+ AssertHelpers.assertThrows("Transaction commit should fail with
CommitStateUnknownException",
+ CommitStateUnknownException.class, "datacenter
on fire",
+ () -> transaction.commitTransaction());
Review comment:
Method arguments are optionally aligned with the start of the first arg
in method definitions. Method calls always use 4 spaces for continuation
indents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
