marton-bod commented on a change in pull request #3748:
URL: https://github.com/apache/iceberg/pull/3748#discussion_r769576474
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java
##########
@@ -98,11 +100,13 @@ private HiveVectorizedReader() {
try {
switch (format) {
case ORC:
- InputSplit split = new OrcSplit(path, null, task.start(),
task.length(), (String[]) null, null,
- false, false, Lists.newArrayList(), 0, task.length(),
path.getParent());
- RecordReader<NullWritable, VectorizedRowBatch> recordReader = null;
- recordReader = new VectorizedOrcInputFormat().getRecordReader(split,
job, reporter);
+ OrcTail orcTail = VectorizedReadUtils.getOrcTail(inputFile, job);
Review comment:
Maybe it'd be useful to have a short comment on why the tail read is
necessary here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
