RussellSpitzer commented on a change in pull request #3753:
URL: https://github.com/apache/iceberg/pull/3753#discussion_r769810538
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -69,13 +69,13 @@ private TableProperties() {
public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L;
// 1s
public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS =
"commit.status-check.max-wait-ms";
- public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L;
// 1 minute
+ public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60 *
1000L; // 1 minute
Review comment:
Not sure why we included the L here, this is the smallest multiplication
we do among these literals :) I think we could just remove it now, or maybe we
should add L on all the constants if we are afraid of overflows ... Doesn't
really matter to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
