wypoon commented on a change in pull request #3722:
URL: https://github.com/apache/iceberg/pull/3722#discussion_r770134237
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -132,6 +166,14 @@ public String extractCatalog(CaseInsensitiveStringMap
options) {
return catalogAndIdentifier(options).catalog().name();
}
+ private static Long propertyAsLong(CaseInsensitiveStringMap options, String
property) {
+ String value = options.get(property);
+ if (value != null) {
+ return Long.parseLong(value);
+ }
Review comment:
Added a blank line.
What is the rationale for always adding a blank line after an if?
I fail to see how this makes the code more readable.
I can understand breaking a large block of code up with blank lines in
general, but this is a very short method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
