RussellSpitzer commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r770927862
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -368,6 +368,10 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
}
Set<T> dictionary = dict(id, lit.comparator());
+ if (dictionary.contains(null)) {
Review comment:
In the other locations a comment is also included
// Allow query engine to make its own decisions regarding SQL 3-valued
boolean logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
