szehon-ho commented on a change in pull request #3760:
URL: https://github.com/apache/iceberg/pull/3760#discussion_r770936345
##########
File path:
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java
##########
@@ -112,5 +159,10 @@ public void testDataWriter() throws IOException {
}
Assert.assertEquals("Written records should match", records,
writtenRecords);
+
+ Assert.assertTrue("Should have a valid lower bound",
dataFile.lowerBounds().containsKey(1));
+ Assert.assertTrue("Should have a valid upper bound",
dataFile.upperBounds().containsKey(1));
+ Assert.assertTrue("Should have a valid lower bound",
dataFile.lowerBounds().containsKey(2));
Review comment:
It seems UnicodeUtil and BinaryUtil truncateMin functions never return
null like truncateMax does (they just truncate to the length and return).
I hope it is ok to have a lowerBound but no upperBound in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
