pvary commented on issue #3750:
URL: https://github.com/apache/iceberg/issues/3750#issuecomment-996537302
@lirui-apache: You are absolutely right that we should delete the warehouse
folders in the `AfterClass`. I am surprised that the directory is not removed
as we create it with `java.nio.file.Files.createTempDirectory("hive",
asFileAttribute(fromString("rwxrwxrwx"))).toFile()`. From the doc:
> As with the createTempFile methods, this method is only part of a
temporary-file facility. A shutdown-hook, or the File.deleteOnExit mechanism
may be used to delete the directory automatically.
Maybe we just have to call after creation?
```
this.hiveLocalDir.deleteOnExit();
```
As for the `TestHiveMetastore .reset()`, I think it would be useful to call
it in the `After` methods to separate the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
