aokolnychyi commented on a change in pull request #3763:
URL: https://github.com/apache/iceberg/pull/3763#discussion_r771475824
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -61,98 +63,32 @@
private static final Logger LOG =
LoggerFactory.getLogger(SparkBatchQueryScan.class);
- private final Long snapshotId;
- private final Long startSnapshotId;
- private final Long endSnapshotId;
- private final Long asOfTimestamp;
- private final Long splitSize;
- private final Integer splitLookback;
- private final Long splitOpenFileCost;
+ private final TableScan scan;
+ private final Context ctx;
Review comment:
I am not a big fan of this class here but it is needed for `equals` and
`hashCode`. Another option I considered was to implement `equals` and
`hashCode` in all `TableScan` implementations. Unfortunately, we have a lot of
such classes and "equal" scans in Spark are a slightly weaker concept (i.e. not
every detail must be the same to consider two scans identical).
Alternatives are welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
