stevenzwu commented on a change in pull request #3501:
URL: https://github.com/apache/iceberg/pull/3501#discussion_r771532224
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
##########
@@ -34,7 +34,7 @@
/**
* Context object with optional arguments for a Flink Scan.
*/
-class ScanContext implements Serializable {
+public class ScanContext implements Serializable {
Review comment:
To clarify, the FLIP-27 source change wasn't trying to fix the
duplication btw `ScanContext` and current `FlinkSource.Builder`. Existing code
stays unchanged. I was just trying to avoid the duplication with the new
FLIP-27 `IcebergSource.Builder` by making `ScanContext` user-facing public and
letting users directly construct the `ScanContext`.
With that said, it seems that both @openinx and @rdblue prefer the current
`FlinkSource.Builder` model where `ScanContext` APIs were duplicated in the
source builder. I will make the change to follow the current pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
