jackye1995 commented on a change in pull request #3535:
URL: https://github.com/apache/iceberg/pull/3535#discussion_r771678746
##########
File path:
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteIndex.java
##########
@@ -38,5 +38,11 @@
* @param position deleted row position
* @return whether the position is deleted
*/
- boolean deleted(long position);
+ boolean isDeleted(long position);
+
+ /**
+ * Returns true if this collection contains no element.
Review comment:
nit: when the javadoc starts with `Returns`, `@return` is not needed
##########
File path:
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java
##########
@@ -39,7 +39,12 @@ public void delete(long posStart, long posEnd) {
}
@Override
- public boolean deleted(long position) {
+ public boolean isDeleted(long position) {
Review comment:
why changing the name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
