wypoon opened a new pull request #3768:
URL: https://github.com/apache/iceberg/pull/3768
Port of #3722 to v3.1.
Notes:
`TestDeleteFrom` in v3.2 has `testDeleteFromUnpartitionedTable` and
`testDeleteFromPartitionedTable` which are note present in v3.1; I had based
the new test, `testDeleteFromTableAtSnapshot` on
`testDeleteFromUnpartitionedTable`, and it is still usable because we don't
actually delete anything, just check that an exception is thrown.
Also, for the negative test cases added in `TestDeleteFrom` and
`TestUnpartitionedWrites`, I had to exclude the `SparkSessionCatalog`
configuration from the parameterized testing, as otherwise I get
```
org.apache.spark.sql.AnalysisException: The namespace in session catalog
must have exactly one name part: default.table.snapshot_id_9024049109842482017
at
org.apache.spark.sql.connector.catalog.LookupCatalog$SessionCatalogAndIdentifier$.unapply(LookupCatalog.scala:65)
```
instead of the `IllegalArgumentException` I was looking for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
