RussellSpitzer commented on a change in pull request #3757:
URL: https://github.com/apache/iceberg/pull/3757#discussion_r771751224
##########
File path:
spark/v3.2/spark/src/main/scala/org/apache/spark/sql/execution/datasources/SparkExpressionConverter.scala
##########
@@ -30,4 +34,18 @@ object SparkExpressionConverter {
// But these two conversions already exist and well tested. So, we are
going with this approach.
SparkFilters.convert(DataSourceStrategy.translateFilter(sparkExpression,
supportNestedPredicatePushdown = true).get)
}
+
+ @throws[AnalysisException]
+ def collectResolvedSparkExpression(session: SparkSession, tableName: String,
where: String): Expression = {
Review comment:
Yep, lgtm. I think we may want to use similar logic in our expire
snapshots procedure as well to allow functions and other Spark things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
