aokolnychyi commented on a change in pull request #3763:
URL: https://github.com/apache/iceberg/pull/3763#discussion_r773308343
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -310,4 +263,62 @@ public String toString() {
"IcebergScan(table=%s, type=%s, filters=%s, runtimeFilters=%s,
caseSensitive=%s)",
table(), expectedSchema().asStruct(), filterExpressions(),
runtimeFilterExpressions, caseSensitive());
}
+
+ static class Context {
Review comment:
Like I wrote
[here](https://github.com/apache/iceberg/pull/3763#discussion_r771475824), I am
not happy with this place either.
For merge-on-read scans, the snapshot ID does not come from `SparkReadConf`.
Instead, it comes from the current table snapshot no matter what.
`SparkScanBuilder` has more context. Let me think more about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
