rdblue commented on a change in pull request #3773:
URL: https://github.com/apache/iceberg/pull/3773#discussion_r773326578
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ApplyNameMapping.java
##########
@@ -97,29 +96,30 @@ public Type primitive(PrimitiveType primitive) {
return field == null ? primitive : primitive.withId(field.id());
}
+ public void beforeField(Type type) {
+ fieldNames.push(type.getName());
+ }
+
+ public void afterField(Type type) {
+ fieldNames.pop();
+ }
+
@Override
public void beforeElementField(Type element) {
- super.beforeElementField(makeElement(element));
+ // normalize the name to "element" so that the mapping will match
structures with alternative names
Review comment:
I don't think so. The main point is that we don't want to care what the
other name was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
