lirui-apache commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r774467865
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -296,7 +298,7 @@ public void testCreateNamespace() throws TException {
catalog.createNamespace(namespace2, newMeta);
Database database2 = metastoreClient.getDatabase(namespace2.toString());
Assert.assertEquals("There no same location for db and namespace",
- database2.getLocationUri(), hiveLocalDir);
+ hiveLocalDir, database2.getLocationUri());
Review comment:
IIUC, `hiveLocalDir` should be the **expected** value, while
`database2.getLocationUri()` should be the **actual** value in this assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
