rdblue commented on a change in pull request #3647:
URL: https://github.com/apache/iceberg/pull/3647#discussion_r774705689



##########
File path: core/src/main/java/org/apache/iceberg/SnapshotProducer.java
##########
@@ -232,6 +232,9 @@ public Snapshot apply() {
 
     ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
 
+    // merge flinkCheckpointInfo from previousSummary into currentSummary when 
rewrite datafiles
+    mergeFlinkCheckpointInfo(builder, previousSummary, summary);

Review comment:
       I don't think that we want to modify core to fix this. Instead of 
carrying metadata forward, I think we should instead look at older snapshots to 
find the max committed ID.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to