rdblue commented on a change in pull request #3552:
URL: https://github.com/apache/iceberg/pull/3552#discussion_r774707420



##########
File path: 
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/RowDataWrapper.java
##########
@@ -80,7 +81,7 @@ public int size() {
     throw new UnsupportedOperationException("Could not set a field in the 
RowDataWrapper because rowData is read-only");
   }
 
-  private interface PositionalGetter<T> {
+  private interface PositionalGetter<T> extends Serializable {

Review comment:
       Yeah, that seems reasonable to me. I would probably update the 
implementation classes.
   
   We should also add tests to validate that the `PositionalGetter` 
implementations are serializable with Java and Kryo.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to