kbendick commented on a change in pull request #3794:
URL: https://github.com/apache/iceberg/pull/3794#discussion_r775081392
##########
File path:
spark/v3.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java
##########
@@ -64,11 +64,11 @@ public void testRewriteDataFilesOnPartitionTable() {
List<Object[]> expectedRecords = currentData();
List<Object[]> output = sql(
- "CALL %s.system.rewrite_data_files(table => '%s')", catalogName,
tableIdent);
+ "CALL %s.system.rewrite_data_files(table => '%s')", catalogName,
tableIdent);
Review comment:
Nit: Usually we try to avoid formatting only changes (even if they are
the correct formatting), as the larger diff makes it harder for people that
maintain forks to cherry-pick commits. If you aren’t changing the line, I’d
suggest leaving it as is.
Same comment applies to all formatting only changes within a PR. 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
