ben-manes commented on a change in pull request #3801:
URL: https://github.com/apache/iceberg/pull/3801#discussion_r775781272
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java
##########
@@ -257,6 +264,44 @@ public void
testCacheExpirationEagerlyRemovesMetadataTables() throws IOException
catalog.cache().asMap().containsKey(metadataTable)));
}
+ @Test
+ @Ignore("reproduces https://github.com/apache/iceberg/issues/3791";)
+ public void testDeadlock() throws IOException, InterruptedException {
+ HadoopCatalog underlyingCatalog = hadoopCatalog();
+ TestableCachingCatalog catalog =
TestableCachingCatalog.wrap(underlyingCatalog, Duration.ofSeconds(1), ticker);
+ Namespace namespace = Namespace.of("db", "ns1", "ns2");
+ int numThreads = 20;
Review comment:
Yes, the key. The map locks on a hashbin so locking multiple in an
unpredictable order is a classic deadlock case. I don’t know if a single entry
would suffice or if you need threads performing ABA vs BAB to get the desired
test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
