hililiwei commented on a change in pull request #3819:
URL: https://github.com/apache/iceberg/pull/3819#discussion_r776773937
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java
##########
@@ -284,7 +284,6 @@ private FlinkParquetReaders() {
public DecimalData read(DecimalData ignored) {
Binary binary = column.nextBinary();
BigDecimal bigDecimal = new BigDecimal(new
BigInteger(binary.getBytes()), scale);
- // TODO: need a unit test to write-read-validate decimal via
FlinkParquetWrite/Reader
Review comment:
This PR is more about using FlinkParquetWrite and Reader to write and
read data at the same time, rather than using either of them alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
