rdblue commented on a change in pull request #3815:
URL: https://github.com/apache/iceberg/pull/3815#discussion_r776877804
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java
##########
@@ -41,7 +41,7 @@
import static org.apache.iceberg.types.Type.TypeID;
abstract class Bucket<T> implements Transform<T, Integer> {
- private static final HashFunction MURMUR3 = Hashing.murmur3_32();
+ private static final HashFunction MURMUR3 = Hashing.murmur3_32_fixed();
Review comment:
Tests are in `TestBucketing`:
https://github.com/apache/iceberg/blob/master/api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java
This tests all of the examples from the spec, as well as type promotion and
some edge cases like UTF-8 with surrogate pairs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
