pvary commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r777431096
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestCatalogTableLoader.java
##########
@@ -58,9 +60,11 @@ public static void createWarehouse() throws IOException {
}
@AfterClass
- public static void dropWarehouse() {
+ public static void dropWarehouse() throws IOException {
if (warehouse != null && warehouse.exists()) {
- warehouse.delete();
+ Path warehousePath = new Path(warehouse.getAbsolutePath());
+ FileSystem fs = warehousePath.getFileSystem(hiveConf);
+ Assert.assertTrue("Failed to delete " + warehousePath,
fs.delete(warehousePath, true));
Review comment:
Taking a fresh look at the code here, I think we might want to do this
cleanup in the `TestHiveMetastore.stop()`.
We already clean up the warehouse root in `TestHiveMetastore.stop()`, we
might want to clean up the data in the stop as well.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
