smallx commented on pull request #3844: URL: https://github.com/apache/iceberg/pull/3844#issuecomment-1005739482
Thanks for reviewing, @rdblue! I updated the code. I use `fastMode` (false by default) just to keep consistent with the behavior of Spark SQL `TRUNCATE TABLE ...`. I didn't notice the possible file leaks problem of `table.expireSnapshots().commit()` before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
