stevenzwu commented on a change in pull request #3817:
URL: https://github.com/apache/iceberg/pull/3817#discussion_r778993369
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java
##########
@@ -19,15 +19,11 @@
package org.apache.iceberg.flink;
-
import org.apache.flink.configuration.ConfigOption;
import org.apache.flink.configuration.ConfigOptions;
public class FlinkConfigOptions {
- private FlinkConfigOptions() {
Review comment:
I think we should revert this change. Iceberg coding style has the
private constructor at the beginning. see `TableProperties` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
