flyrain commented on a change in pull request #3851:
URL: https://github.com/apache/iceberg/pull/3851#discussion_r779759010
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -211,6 +214,18 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
}
}
+ @Override
+ public org.apache.iceberg.Table registerTable(TableIdentifier identifier,
String metadataFileLocation) {
+ Preconditions.checkArgument(isValidIdentifier(identifier), "Invalid
identifier: %s", identifier);
+
+ TableOperations ops = newTableOps(identifier);
+ HadoopInputFile metadataFile =
HadoopInputFile.fromLocation(metadataFileLocation, conf);
Review comment:
Agree with Szehon. `fileIO` should be used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
