hililiwei commented on pull request #3817: URL: https://github.com/apache/iceberg/pull/3817#issuecomment-1007072575
> Thanks for taking this on @hililiwei! > > I left a few nits / open questions. > > Can we also add a test that disables locality and then performs a read to ensure that the new `FlinkInputSplit` works correctly when locality is disabled? @kbendick Thanks for your review. I'll try to add a unit test, and keep reported when get any progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
