kbendick commented on a change in pull request #3813:
URL: https://github.com/apache/iceberg/pull/3813#discussion_r780534493
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -209,6 +209,12 @@
*/
public static final String CLIENT_ASSUME_ROLE_REGION =
"client.assume-role.region";
+ /**
+ * Enables eTag checks for S3 PUT and MULTIPART upload requests.
+ */
+ public static final String CLIENT_ENABLE_ETAG_CHECK =
"client.enable.etag-check";
Review comment:
I'm a big fan of `s3` as the prefix, and then `s3.checksum.enabled`
would be my preferred choice.
This really explains what the intent is, vs etag-check more explains how it
works and isn't as informative for users who don't know the underlying details
of S3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
