rdblue commented on a change in pull request #3728:
URL: https://github.com/apache/iceberg/pull/3728#discussion_r780822348
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java
##########
@@ -118,6 +119,8 @@ protected long waitUntilAfter(long timestampMillis) {
return row.getList(pos);
} else if (value instanceof scala.collection.Map) {
return row.getJavaMap(pos);
+ } else if (value.getClass().isArray() &&
value.getClass().getComponentType().isPrimitive()) {
+ return IntStream.range(0, Array.getLength(value)).mapToObj(i ->
Array.get(value, i)).toArray();
Review comment:
This representation should not change for tests. I think that the
original type is correct. If you need to fix tests that are failing because of
array comparison, then you should update the assertions instead of runtime code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
