rdblue commented on a change in pull request #3837:
URL: https://github.com/apache/iceberg/pull/3837#discussion_r780823469
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -164,19 +164,25 @@ public Table loadTable(TableIdentifier ident) {
@Override
public boolean dropTable(TableIdentifier ident, boolean purge) {
boolean dropped = catalog.dropTable(ident, purge);
- invalidate(canonicalizeIdentifier(ident));
+ invalidate(ident);
return dropped;
}
@Override
public void renameTable(TableIdentifier from, TableIdentifier to) {
catalog.renameTable(from, to);
- invalidate(canonicalizeIdentifier(from));
+ invalidate(from);
+ }
+
+ @Override
+ public void invalidateTable(TableIdentifier ident) {
Review comment:
Minor: I don't think that we need both this and the private `invalidate`
method, since this just calls the private one. We could just call
`invalidateTable` everywhere instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
