rdblue commented on a change in pull request #3857:
URL: https://github.com/apache/iceberg/pull/3857#discussion_r780839138



##########
File path: core/src/main/java/org/apache/iceberg/SerializableTable.java
##########
@@ -107,7 +108,7 @@ private String metadataFileLocation(Table table) {
 
   private FileIO fileIO(Table table) {
     if (table.io() instanceof HadoopConfigurable) {
-      ((HadoopConfigurable) table.io()).serializeConfWith(conf -> new 
SerializableConfiguration(conf)::get);
+      ((HadoopConfigurable) 
table.io()).serializeConfWith(SerializableConfSupplier::new);

Review comment:
       What's happening is that the lambda is creating a 
`SerializableConfiguration` and returning its `get` method as a lambda that 
implements `SerializableSupplier`. In the new version, the lambda is removed 
and the returned object is a `SerializableSupplier`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to