rdblue commented on a change in pull request #3863:
URL: https://github.com/apache/iceberg/pull/3863#discussion_r780839796
##########
File path:
spark/v3.0/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DynamicFileFilterExec.scala
##########
@@ -41,6 +43,11 @@ abstract class DynamicFileFilterExecBase(
@transient
override lazy val references: AttributeSet =
AttributeSet(fileFilterExec.output)
+ override lazy val metrics = Map(
+ "totalFiles" -> SQLMetrics.createMetric(sparkContext, "total number of
files"),
Review comment:
Can you make these display names a bit shorter and capitalize them? I
think they should be "Candidate files" and "Matching files". Those are
descriptive, but short.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
